This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
refactor resource requests and limits for init containers and lifecycle sidecar #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resources to consul-k8s
thisisnotashwin
approved these changes
Jul 7, 2020
lkysow
reviewed
Jul 7, 2020
|
Oh, we also need to add tests that the resources are getting set as expected for the gateways and for connect-inject that those flags are being passed as expected. There's already some tests there that you can look at. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now define resources for the connect inject init copy container in values.yaml and standardize usage of CPU Limit/Request and Memory Limit/Request for it across the ingress/terminating/mesh gateways and connect-inject deployments via new entries in the values.yaml file.
These are passed in as command line arguments to consul-k8s and are thereby are now configurable.
This PR resolves #515 and resolves #529 by increasing the default cpu request+limit and memory limit, respectively, making them configurable to the user.