This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Apply license until success #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
ent-license-job-wait
branch
from
7444b1b to
0db9e52
Compare
ishustava
reviewed
Feb 13, 2020
There was a problem hiding this comment.
@lkysow Thank you for fixing this 💯 I added a couple of thoughts inline.
I think this works as a short-term solution, but I thought we were talking about adding a command to consul-k8s to wait for servers to be ready and then re-using it here and for acl-init. I might be misremembering though.
Previously, if the leader wasn't elected, the consul license command would be run once in each execution of the job and fail. On clusters where the servers took a long time to come up, the job would reach its maximum backoff limit and the license would never be applied. This change runs the license put command in a loop until it's successful or it times out after 20 minutes.
lkysow
force-pushed
the
ent-license-job-wait
branch
from
0db9e52 to
83acf1e
Compare
|
@ishustava good call on just running the command in a loop. That's way better. I've modified my changes accordingly and am using the |
lkysow
changed the title
ishustava
approved these changes
Mar 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the leader wasn't elected, the consul license command
would be run once in each execution of the job and fail.
On clusters where the servers took a long time to come up,
the job would reach its maximum backoff limit and the license would
never be applied.
This change runs the license put command in a loop until it's
successful or it times out after 20 minutes.
Logs look like: