This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add -job to filename to match convention #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
approved these changes
Jan 2, 2020
test/unit/server-statefulset.bats
Outdated
| @@ -383,7 +383,7 @@ load _helpers | |||
| @test "server/StatefulSet: gossip encryption disabled in server StatefulSet when servers are disabled" { | |||
| cd `chart_dir` | |||
| local actual=$(helm template \ | |||
| -x templates/enterprise-license.yaml \ | |||
| -x templates/enterprise-license-job.yaml \ | |||
There was a problem hiding this comment.
🤔 this should be templates/server-statefulset.yaml.
There was a problem hiding this comment.
Nice catch. Actually that test doesn't make any sense because it's looking for certain keys within the server statefulset when servers are disabled. When servers are disabled then the statefulset isn't rendered at all so I just deleted the test.
This test was checking for config within the server statefulset when servers were disabled. This didn't make sense because when servers are disable the statefulset isn't rendered at all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enterprise-licence.yaml=>enterprise-license-job.yaml