Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add flag for turning off tests #249

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Add flag for turning off tests #249

merged 3 commits into from
Oct 17, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Oct 15, 2019

Useful in the case where users are running helm template and they don't want the test Pod submitted. When running helm install, helm won't submit the Pod, only if users manually run helm test.

Adds docs to #144, closes #144

@lkysow lkysow requested a review from ishustava October 15, 2019 18:46
@lkysow lkysow force-pushed the tests-optional branch 2 times, most recently from 98ff083 to 706e1f6 Compare October 15, 2019 18:52
@lkysow lkysow added area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field enhancement New feature or request labels Oct 17, 2019
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think it'd be nice to add a unit test for this.

@lkysow lkysow requested a review from ishustava October 17, 2019 21:07
@lkysow
Copy link
Member Author

lkysow commented Oct 17, 2019

This looks good, but I think it'd be nice to add a unit test for this.

Good call, I just added a test for the flag on/off rather than the contents of the Pod manifest since that unnecessary but happy to add a bit more template testing if you think it's warranted.

Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lkysow lkysow merged commit 5d42e2f into master Oct 17, 2019
@lkysow lkysow deleted the tests-optional branch October 17, 2019 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants