Upgrade api to ember 4.12 #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
commented
Aug 9, 2023
| @@ -82,7 +82,8 @@ | |||
| "**/@storybook/**/ansi-regex": "^5.0.1", | |||
| "**/jsprim/json-schema": "^0.4.0", | |||
| "**/@storybook/**/yuidocjs/markdown-it": "^12.3.2", | |||
| "**/ember-cli/markdown-it-terminal/markdown-it": "^12.3.2" | |||
| "**/ember-cli/markdown-it-terminal/markdown-it": "^12.3.2", | |||
| "**/ember-cli-mirage/@embroider/macros": "^1.0.0" | |||
There was a problem hiding this comment.
DhariniJeeva
reviewed
Aug 9, 2023
DhariniJeeva
approved these changes
Aug 9, 2023
calcaide
reviewed
Aug 9, 2023
| @@ -10,67 +10,70 @@ | |||
| "scripts": { | |||
| "build:development": "ember build", | |||
| "build": "ember build --environment=production", | |||
| "lint": "npm-run-all --aggregate-output --continue-on-error --parallel \"lint:!(fix)\"", | |||
| "lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*:fix", | |||
| "lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"", | |||
There was a problem hiding this comment.
None blocking comment: I guess ember-cli deprecated npm-run-all and installed concurrently? or we did so?
There was a problem hiding this comment.
Yeah this was all ember-cli 😆
calcaide
approved these changes
Aug 9, 2023
ZedLi
commented
Aug 11, 2023
| const pluginName = snapshot.attr('plugin')?.name; | ||
| if (pluginName) url = `${url}?plugin_name=${pluginName}`; | ||
| } catch (e) { | ||
| // Ignore any adapter errors here |
There was a problem hiding this comment.
These try catches are needed now because for some reason, if there's a 404 you get a cache error by just trying to access the snapshot attribute
ZedLi
commented
Aug 11, 2023
| @@ -124,10 +123,7 @@ module('Acceptance | authentication', function (hooks) { | |||
|
|
|||
| test('visiting auth method when the scope cannot be loaded is still allowed', async function (assert) { | |||
| assert.expect(1); | |||
| setupOnerror(() => { | |||
There was a problem hiding this comment.
Seems like this doesn't work anymore, possibly because ember changed what uses ember runloop in the most recent changes and this only catches things on the runloop.
Either way it doesn't appear it's needed in the first place since we weren't mocking the correct route anyways
DhariniJeeva
approved these changes
Aug 14, 2023
cameronperera
approved these changes
Aug 14, 2023
ZedLi
added a commit
that referenced
this pull request
Aug 14, 2023
* chore: 🤖 Upgrade API layer to ember 4.12 * chore: 🤖 Upgrade ember-data to 4.12 * fix: 🐛 Fix breaking change from usage of internal method * chore: 🤖 Remove stylelint in API addon * test: 💍 Fix broken API tests * chore: 🤖 get rid of toArray * test: 💍 Fix tests broken by ember data changes --------- Co-authored-by: dharini <[email protected]>
ZedLi
added a commit
that referenced
this pull request
Aug 14, 2023
* chore: 🤖 Upgrade API layer to ember 4.12 * chore: 🤖 Upgrade ember-data to 4.12 * fix: 🐛 Fix breaking change from usage of internal method * chore: 🤖 Remove stylelint in API addon * test: 💍 Fix broken API tests * chore: 🤖 get rid of toArray * test: 💍 Fix tests broken by ember data changes --------- Co-authored-by: dharini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial upgrade of ember and ember-data to 4.12 for API addon.