Fix darwin arm64 builds #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sometimes this may not have been happening due to product build parameters affecting the CLI build.
samsalisbury
requested review from
a team,
shore and
sarahethompson
and removed request for
a team
shore
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
Building
darwin/arm64binaries is currently broken: https://hashicorp.slack.com/archives/C01A1M2QQ1Z/p1666385357957249Summary
Ensure that builds and tests of the actions-go-build CLI are done for the host platform, not the target platform.
Quality
All changes to behavior should be accompanied by relevant tests which both document and protect it.
This PR includes: