fix: clear time in RuningClockDatePicker #1517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icoxxx
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 158 159 +1
Lines 5919 5934 +15
Branches 1088 1088
=======================================
+ Hits 5864 5879 +15
Misses 52 52
Partials 3 3 see 2 files with indirect coverage changes |
SvetBorislavov
previously approved these changes
Feb 6, 2025
icoxxx
force-pushed
the
1464-selecting-new-date-for-a-transaction-should-clear-the-time
branch
from
5c92c86 to
5c9855e
Compare
jbair06
requested changes
Feb 6, 2025
|
I've created issue #1529 that has a couple of improvements that should be added to this PR, if possible. This UX improvements will help make it smoother. |
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
icoxxx
force-pushed
the
1464-selecting-new-date-for-a-transaction-should-clear-the-time
branch
from
5c9855e to
986dea7
Compare
text-input and flow options are now used. 'Now' button now works like the stock now button of the DatePicker component. Signed-off-by: John Bair <[email protected]>
jbair06
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reset time to default value (00:00) on selecting a new date in RuningClockDatePicker component
Related issue(s):
#1464