Optimize eth_getLogs()

[dimitrovmaksim]

Signed-off-by: Maksim Dimitrov [email protected]

Description:
Removes now obsolete queries to the mirror node for each log to fetch block and transaction data

Related issue(s):

Fixes #389

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[codecov-commenter]

Codecov Report

Base: 71.21% // Head: 70.74% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (3fd254b) compared to base (0fe1739).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   71.21%   70.74%   -0.47%     
==========================================
  Files          16       16              
  Lines        1157     1135      -22     
  Branches      198      195       -3     
==========================================
- Hits          824      803      -21     
  Misses        279      279              
+ Partials       54       53       -1     

Impacted Files	Coverage Δ
packages/relay/src/lib/eth.ts	83.23% <100.00%> (-0.53%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dimitrovmaksim]

I'm not sure if 567 is the correct timeout status code https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/packages/relay/src/lib/errors/MirrorNodeClientError.ts#L26. Currently I think 2 eth_getLogs tests are using this as a timeout code, but it also returns 567 if a mock for a specific request is not found. One of the tests now passes, but actually the error reason is that there's no mock for the request -

hedera-json-rpc-relay/packages/relay/tests/lib/eth.spec.ts

Line 1339 in 536e203

mock.onGet(`contracts/${contractAddress1}/results/logs`).reply(567, timeoutError);

MirrorNodeClientError: Could not find mock for: 
{
  "method": "get",
  "url": "contracts/0x000000000000000000000000000000000000055f/results/logs?timestamp=gte:1651560386.060890949&timestamp=lte:1651560389.060890949"
}
    at MirrorNodeClient.handleError (/Users/maksimdimitrov/Projects/hedera/hedera-json-rpc-relay/packages/relay/src/lib/clients/mirrorNodeClient.ts:21:2947)
    at MirrorNodeClient.<anonymous> (/Users/maksimdimitrov/Projects/hedera/hedera-json-rpc-relay/packages/relay/src/lib/clients/mirrorNodeClient.ts:21:1894)
    at Generator.throw (<anonymous>)
    at rejected (/Users/maksimdimitrov/Projects/hedera/hedera-json-rpc-relay/packages/relay/src/lib/clients/mirrorNodeClient.ts:19:4) {
  statusCode: 567
}

The actual mocked requests should be

mock.onGet(`contracts/${contractAddress1}/results/logs?timestamp=gte:${defaultBlock.timestamp.from}&timestamp=lte:${defaultBlock.timestamp.to}`).reply(567, timeoutError);

but the tests till passes

CC: @Nana-EC

[dimitrovmaksim]

I think I figured it out. Timeouts will not have a response property so it will always return unknownServerErrorHttpStatusCode which is 567

hedera-json-rpc-relay/packages/relay/src/lib/clients/mirrorNodeClient.ts

Line 158 in 536e203

const effectiveStatusCode = error.response !== undefined ? error.response.status : MirrorNodeClient.unknownServerErrorHttpStatusCode;

Timeouts will have error.code == ECONNABORTED

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Nana-EC]

LG, just waiting on passing tests

[georgi-l95]

LGTM!