Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rate Limiter Tiers for Development Tools #613

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

georgi-l95
Copy link
Member

Signed-off-by: georgi-l95 [email protected]

Description:

  • Adjust tier requests per ip, to avoid rate limiting when deploying larger contracts.
  • Add note to docs

Related issue(s):

Fixes #609

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <[email protected]>
@georgi-l95 georgi-l95 added enhancement New feature or request limechain P2 labels Oct 12, 2022
@georgi-l95 georgi-l95 added this to the 0.10 milestone Oct 12, 2022
@georgi-l95 georgi-l95 self-assigned this Oct 12, 2022
@georgi-l95 georgi-l95 linked an issue Oct 12, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Base: 71.21% // Head: 71.21% // No change to project coverage 👍

Coverage data is based on head (a4ad4cc) compared to base (f2a7152).
Patch has no changes to coverable lines.

❗ Current head a4ad4cc differs from pull request most recent head b14ae37. Consider uploading reports for the commit b14ae37 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files          16       16           
  Lines        1157     1157           
  Branches      198      198           
=======================================
  Hits          824      824           
  Misses        279      279           
  Partials       54       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
Assuming we tested locally for Truffle and The Graph

@Nana-EC Nana-EC requested a review from lukelee-sl October 12, 2022 18:46
@georgi-l95 georgi-l95 merged commit 0fe1739 into main Oct 12, 2022
@georgi-l95 georgi-l95 deleted the 609-improve-tiered-rate-limit-for-dev-tools branch October 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve tiered rate limit for dev tools
4 participants