Update eth_transactioncount to use mirror (0.8) #557
Conversation
Update eth_transactionaccount to use mirror node Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Nana-EC
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 74.92% // Head: 74.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/0.8 #557 +/- ##
===============================================
- Coverage 74.92% 74.50% -0.42%
===============================================
Files 12 12
Lines 961 969 +8
Branches 150 152 +2
===============================================
+ Hits 720 722 +2
- Misses 194 198 +4
- Partials 47 49 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| return EthImpl.zeroHex; | ||
| } else if (address && !blockNumOrTag) { | ||
| // get latest ethereumNonce | ||
| const mirrorAccount = await this.mirrorNodeClient.getAccount(address, requestId); |
There was a problem hiding this comment.
I just want to confirm mirror node is now always up to date, not not up to 15 minutes behind anymore.
There was a problem hiding this comment.
Correct the api/v1/accounts was always up to data for account info but is now also up to data for balance info.
api/v1/balance is still on the 15 min behind schedule until mirror node updates it's logic
Update eth_transactionaccount to use mirror node
Signed-off-by: Nana Essilfie-Conduah [email protected]
Description:
Cherry pick #552 to release 0.8
Related issue(s):
Addresses #550
Notes for reviewer:
Checklist