Log fileId and file size for callData #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <[email protected]>
Codecov ReportBase: 76.75% // Head: 75.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
- Coverage 76.75% 75.23% -1.53%
==========================================
Files 12 12
Lines 938 957 +19
Branches 144 149 +5
==========================================
Hits 720 720
- Misses 171 190 +19
Partials 47 47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Sep 21, 2022
lukelee-sl
added a commit
that referenced
this pull request
Sep 21, 2022
Log details about the file created for callData when calling a transaction. Signed-off-by: lukelee-sl <[email protected]>
lukelee-sl
added a commit
that referenced
this pull request
Sep 21, 2022
Log details about the file created for callData when calling a transaction. Signed-off-by: lukelee-sl <[email protected]>
lukelee-sl
added a commit
that referenced
this pull request
Sep 21, 2022
Log details about the file created for callData when calling a transaction. Signed-off-by: lukelee-sl <[email protected]>
lukelee-sl
added a commit
that referenced
this pull request
Sep 21, 2022
* Log fileId and file size for callData Signed-off-by: lukelee-sl <[email protected]> * make createFile function private Signed-off-by: lukelee-sl <[email protected]> * createFile should only take callData Signed-off-by: lukelee-sl <[email protected]> * clear callData after file creation Signed-off-by: lukelee-sl <[email protected]> * do not create file for contracts <= 5120 bytes Signed-off-by: lukelee-sl <[email protected]> * Log fileId and file size for callData (#541) Log details about the file created for callData when calling a transaction. Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lukelee-sl [email protected]
Description:
Log details about the file created for callData when calling a transaction.
Fixes #540
Notes for reviewer:
Checklist