Update eth_getBalance to use mirror node #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Nana-EC
requested review from
natanasow,
lukelee-sl,
georgi-l95 and
shemnon
Codecov ReportBase: 76.67% // Head: 76.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 76.67% 76.54% -0.13%
==========================================
Files 12 12
Lines 926 921 -5
Branches 145 140 -5
==========================================
- Hits 710 705 -5
- Misses 164 166 +2
+ Partials 52 50 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
georgi-l95
reviewed
Sep 18, 2022
| @@ -507,25 +507,18 @@ export class EthImpl implements Eth { | |||
|
|
|||
There was a problem hiding this comment.
10 lines above this, there is a comment, which I think can be removed now with this PR.
georgi-l95
requested changes
Sep 18, 2022
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
lukelee-sl
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana Essilfie-Conduah [email protected]
Description:
eth_getBalancecurrently uses the consensus nodes to retrieve balance since mirror node only update balance every 15 mins.With mirror node fix to update on transfers relay can now point to mirror node
eth_getBalancelogic to call Mirror Node /api/v1/accounts` endpoint and extract balanceresolvedCostRelated issue(s):
Fixes #448
Notes for reviewer:
Checklist