Enable pending acceptance tests #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/server/tests/acceptance/htsPrecompile.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
Codecov ReportBase: 76.38% // Head: 76.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
+ Coverage 76.38% 76.67% +0.29%
==========================================
Files 12 12
Lines 923 926 +3
Branches 144 145 +1
==========================================
+ Hits 705 710 +5
+ Misses 165 164 -1
+ Partials 53 52 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Nana-EC
previously approved these changes
Sep 16, 2022
Signed-off-by: Ivo Yankov <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
|
Moving changes from this PR to #464 to simplify merging |
Nana-EC
added a commit
that referenced
this pull request
Sep 20, 2022
Adds tests for getTokenKey and updateTokenKeys. Applies changes from PR #524 Adds a new acceptance test suite - htsPrecompile_v2 in order to reduce the size of BaseHTS.sol so that the bytecode doesn't exceed 24kb. Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Nana Essilfie-Conduah <[email protected]> Co-authored-by: Nana Essilfie-Conduah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Re-enables tests for:
wipeTokenAccount,wipeTokenAccountNFTallowance,transferFromRelated issue(s):
Fixes #521
Notes for reviewer:
Checklist