-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subgraph example #500
Add subgraph example #500
Conversation
Signed-off-by: Maksim Dimitrov <[email protected]>
Signed-off-by: Maksim Dimitrov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 12 12
Lines 923 923
Branches 144 144
=======================================
Hits 705 705
Misses 165 165
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Maksim Dimitrov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, some suggestions.
Signed-off-by: Maksim Dimitrov <[email protected]>
Addressed the comments. No idea why the acceptance tests suddenly failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Forgot the @
sign in the package but unblocking in case you get others to sign off on the fix during your day
tools/subgraph-example/package.json
Outdated
@@ -0,0 +1,20 @@ | |||
{ | |||
"name": "hedera-subgraph-greeter-example", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed the @
in the previous comment
"name": "hedera-subgraph-greeter-example", | |
"name": "@hedera-subgraph-greeter-example", |
I would also like to know the cause of these |
Signed-off-by: Maksim Dimitrov <[email protected]>
Signed-off-by: Maksim Dimitrov <[email protected]>
Merged main an that fixed it 🤷🏻 |
Signed-off-by: Maksim Dimitrov <[email protected]>
e1e3517
to
ffbaba3
Compare
LG. Might want to rebase and make sure you got the fix from #503 |
It should have the latest from main |
Strange. The DApp tests seems to be hanging like they were before the fix. |
It seems this change https://github.com/hashgraph/hedera-json-rpc-relay/pull/467/files#diff-5d2618f4c6bdf4bfe643f5daa3ba86bdac78d28fdea322669560aad211eedc8fL21-R34 reverts this change https://github.com/hashgraph/hedera-json-rpc-relay/pull/503/files#diff-5d2618f4c6bdf4bfe643f5daa3ba86bdac78d28fdea322669560aad211eedc8fL21-R21, not sure if this is the reason |
Likely the reason. |
Signed-off-by: Maksim Dimitrov <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
@dimitrovmaksim all your commits need to be signed |
Closing in favour of #525 |
Signed-off-by: Maksim Dimitrov [email protected]
Description:
Adds a subgraph example with a modified Greeter contract that emits an event on
setGreeting
Related issue(s):
Fixes #487
Notes for reviewer:
Checklist