Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subgraph example #500

Closed
wants to merge 8 commits into from
Closed

Add subgraph example #500

wants to merge 8 commits into from

Conversation

dimitrovmaksim
Copy link
Collaborator

Signed-off-by: Maksim Dimitrov [email protected]

Description:

Adds a subgraph example with a modified Greeter contract that emits an event on setGreeting

Related issue(s):

Fixes #487

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@dimitrovmaksim dimitrovmaksim changed the title Add subgraph example. Update Greeter contract to emit an event. Add subgraph example Sep 7, 2022
@dimitrovmaksim dimitrovmaksim self-assigned this Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #500 (ffbaba3) into main (c85f187) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          12       12           
  Lines         923      923           
  Branches      144      144           
=======================================
  Hits          705      705           
  Misses        165      165           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Maksim Dimitrov <[email protected]>
@Nana-EC Nana-EC added enhancement New feature or request P2 dev tools Features enabling dev tool integration labels Sep 8, 2022
@Nana-EC Nana-EC added this to the 0.8.0 milestone Sep 8, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some suggestions.

Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
Copy link
Collaborator Author

dimitrovmaksim commented Sep 8, 2022

Addressed the comments. No idea why the acceptance tests suddenly failed

Nana-EC
Nana-EC previously approved these changes Sep 9, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Forgot the @ sign in the package but unblocking in case you get others to sign off on the fix during your day

@@ -0,0 +1,20 @@
{
"name": "hedera-subgraph-greeter-example",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have missed the @ in the previous comment

Suggested change
"name": "hedera-subgraph-greeter-example",
"name": "@hedera-subgraph-greeter-example",

@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 9, 2022

Addressed the comments. No idea why the acceptance tests suddenly failed

I would also like to know the cause of these

Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
Copy link
Collaborator Author

I would also like to know the cause of these

Merged main an that fixed it 🤷🏻

Nana-EC
Nana-EC previously approved these changes Sep 9, 2022
@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 12, 2022

LG. Might want to rebase and make sure you got the fix from #503

@dimitrovmaksim
Copy link
Collaborator Author

LG. Might want to rebase and make sure you got the fix from #503

It should have the latest from main

@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 12, 2022

LG. Might want to rebase and make sure you got the fix from #503

It should have the latest from main

Strange. The DApp tests seems to be hanging like they were before the fix.

@dimitrovmaksim
Copy link
Collaborator Author

LG. Might want to rebase and make sure you got the fix from #503

It should have the latest from main

Strange. The DApp tests seems to be hanging like they were before the fix.

It seems this change https://github.com/hashgraph/hedera-json-rpc-relay/pull/467/files#diff-5d2618f4c6bdf4bfe643f5daa3ba86bdac78d28fdea322669560aad211eedc8fL21-R34 reverts this change https://github.com/hashgraph/hedera-json-rpc-relay/pull/503/files#diff-5d2618f4c6bdf4bfe643f5daa3ba86bdac78d28fdea322669560aad211eedc8fL21-R21, not sure if this is the reason

@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 12, 2022

LG. Might want to rebase and make sure you got the fix from #503

It should have the latest from main

Strange. The DApp tests seems to be hanging like they were before the fix.

It seems this change https://github.com/hashgraph/hedera-json-rpc-relay/pull/467/files#diff-5d2618f4c6bdf4bfe643f5daa3ba86bdac78d28fdea322669560aad211eedc8fL21-R34 reverts this change https://github.com/hashgraph/hedera-json-rpc-relay/pull/503/files#diff-5d2618f4c6bdf4bfe643f5daa3ba86bdac78d28fdea322669560aad211eedc8fL21-R21, not sure if this is the reason

Likely the reason.
Defer that line to be the main branch current version unless your tests need it to be otherwise

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 15, 2022

@dimitrovmaksim all your commits need to be signed

@dimitrovmaksim
Copy link
Collaborator Author

Closing in favour of #525

@dimitrovmaksim dimitrovmaksim deleted the add-subgraph-example branch September 16, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev tools Features enabling dev tool integration enhancement New feature or request P2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add an example subgraph project in the relay
3 participants