Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node container image versions used in acceptance tests #362

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Update node container image versions used in acceptance tests #362

merged 3 commits into from
Jul 21, 2022

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jul 20, 2022

Signed-off-by: Nana-EC [email protected]

Description:
Update node container image versions used in acceptance tests

Related issue(s):

Fixes #331

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC self-assigned this Jul 20, 2022
@Nana-EC Nana-EC changed the title Update acceptance test images Update node container image versions used in acceptance tests Jul 20, 2022
@Nana-EC Nana-EC added enhancement New feature or request P2 process Build, test and deployment-process related tasks labels Jul 20, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #362 (46dcf33) into main (1caac90) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   62.35%   62.21%   -0.15%     
==========================================
  Files           9        9              
  Lines         866      868       +2     
  Branches      142      142              
==========================================
  Hits          540      540              
- Misses        288      290       +2     
  Partials       38       38
Impacted Files Coverage Δ
packages/relay/src/lib/eth.ts 65.22% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caac90...46dcf33. Read the comment docs.

lukelee-sl
lukelee-sl previously approved these changes Jul 20, 2022
View reviewed changes
@Nana-EC Nana-EC requested review from ar-conmit and natanasow July 21, 2022 14:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

natanasow
natanasow approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC merged commit 96c6764 into main Jul 21, 2022
@Nana-EC Nana-EC deleted the 331-update-local-node-images branch July 21, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natanasow natanasow natanasow approved these changes

@lukelee-sl lukelee-sl lukelee-sl left review comments

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

@shemnon shemnon Awaiting requested review from shemnon

@ar-conmit ar-conmit Awaiting requested review from ar-conmit

Assignees

@Nana-EC Nana-EC

Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Update docker image version for services in acceptance tests
4 participants
@Nana-EC @codecov-commenter @natanasow @lukelee-sl