-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metamask window does not popup on DApp tests #357
Conversation
Signed-off-by: Anton Rusev <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 62.35% 62.35%
=======================================
Files 9 9
Lines 874 874
Branches 143 143
=======================================
Hits 545 545
Misses 291 291
Partials 38 38 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Can you please update the PR comment to highlight why removing these lines fixes the issue
To be honest, I am not sure. Just tried some things and it turned out that this combination is working. I have run 30+ tests on previewnet and no failing popup occurred. |
Signed-off-by: Anton Rusev [email protected]
Description:
Related issue(s):
Fixes #347
Notes for reviewer:
Checklist