Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask window does not popup on DApp tests #357

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

ar-conmit
Copy link
Collaborator

Signed-off-by: Anton Rusev [email protected]

Description:

Related issue(s):

Fixes #347

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@codecov-commenter
Copy link

Codecov Report

Merging #357 (b6b089e) into main (cc9ba38) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   62.35%   62.35%           
=======================================
  Files           9        9           
  Lines         874      874           
  Branches      143      143           
=======================================
  Hits          545      545           
  Misses        291      291           
  Partials       38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9ba38...b6b089e. Read the comment docs.

@Nana-EC Nana-EC added bug Something isn't working limechain P1 process Build, test and deployment-process related tasks dev tools Features enabling dev tool integration labels Jul 20, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 20, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Can you please update the PR comment to highlight why removing these lines fixes the issue

@Nana-EC Nana-EC requested a review from lukelee-sl July 20, 2022 14:28
@ar-conmit
Copy link
Collaborator Author

LG
Can you please update the PR comment to highlight why removing these lines fixes the issue

To be honest, I am not sure. Just tried some things and it turned out that this combination is working. I have run 30+ tests on previewnet and no failing popup occurred.

@Nana-EC Nana-EC merged commit 735578d into main Jul 20, 2022
@Nana-EC Nana-EC deleted the 347-dapp-metamask-window-popup-issue branch July 20, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev tools Features enabling dev tool integration limechain P1 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metamask window does not popup on DApp tests
4 participants