-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: block gas limit should be 30_000_000 #2938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
victor-yanev
approved these changes
Sep 4, 2024
quiet-node
approved these changes
Sep 4, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
========================================
Coverage 84.39% 84.40%
========================================
Files 40 56 +16
Lines 3057 3770 +713
Branches 632 771 +139
========================================
+ Hits 2580 3182 +602
- Misses 276 351 +75
- Partials 201 237 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When querying block information, the block gasLimit is shown as 15M GAS (15000000). The correct value should be 30M GAS (30000000). This happens for all public networks (mainnet, testnet and previewnet).
Related issue(s):
Fixes #2740
Notes for reviewer:
We were using max gas per sec as a block limit gas which is incorrect. In the hedera ecosystem, there is a limit of up to
15 000 000
gas per sec (here) which means that a single transaction could use max15 000 000
as a gas limit. Meanwhile one "block" is generated every 2 seconds which means that max block gas is30 0000 000
=15 000 000
per sec *2
sec.Checklist