fix: removed nonce precheck buffer (#2919) #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: removed nonce precheck buffer Signed-off-by: Logan Nguyen <[email protected]> * fix: unwrapped INTERAL_ERROR if error is an instance of JsonRpcError for the WS object Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
ebadiere
requested review from
AlfredoG87,
georgi-l95,
Ivo-Yankov,
a team and
lukelee-sl
as code owners
|
quiet-node
approved these changes
Sep 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.55 #2936 +/- ##
================================================
+ Coverage 84.21% 84.65% +0.44%
================================================
Files 40 59 +19
Lines 3040 3904 +864
Branches 635 807 +172
================================================
+ Hits 2560 3305 +745
- Misses 278 335 +57
- Partials 202 264 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: removed nonce precheck buffer
fix: unwrapped INTERAL_ERROR if error is an instance of JsonRpcError for the WS object
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist