Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updating the workflows/actions to use the step-security version. #2924

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Sep 2, 2024

Description:
Updating actions from workflows to use the step-security maintained version.

Related issue(s):

Fixes #2906

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@san-est san-est self-assigned this Sep 2, 2024
@san-est san-est requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners September 2, 2024 08:33
@san-est san-est linked an issue Sep 2, 2024 that may be closed by this pull request
1 task
@san-est san-est requested a review from nathanklick September 2, 2024 08:33
Copy link

github-actions bot commented Sep 2, 2024

Tests

       3 files     274 suites   19s ⏱️
1 285 tests 1 284 ✔️ 1 💤 0
1 297 runs  1 296 ✔️ 1 💤 0

Results for commit 55320a5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 2, 2024

Acceptance Tests

  20 files  293 suites   31m 2s ⏱️
601 tests 570 ✔️ 4 💤 27
797 runs  766 ✔️ 4 💤 27

Results for commit 55320a5.

♻️ This comment has been updated with latest results.

@san-est san-est force-pushed the 2906-ci-update-nickfieldsretry-to-step-security-maintained-version branch from 8810478 to 3d18262 Compare September 4, 2024 10:10
@san-est san-est added this to the 0.56.0 milestone Sep 4, 2024
@san-est san-est changed the title Updating the workflows/actions to use the step-security version. ci: Updating the workflows/actions to use the step-security version. Sep 4, 2024
@san-est san-est force-pushed the 2906-ci-update-nickfieldsretry-to-step-security-maintained-version branch from 3d18262 to 7e85016 Compare September 4, 2024 11:18
isavov
isavov previously approved these changes Sep 4, 2024
quiet-node
quiet-node previously approved these changes Sep 4, 2024
@san-est san-est dismissed stale reviews from quiet-node and isavov via 32b0c37 September 5, 2024 06:45
rbarker-dev
rbarker-dev previously approved these changes Sep 5, 2024
Copy link

@quiet-node quiet-node added the enhancement New feature or request label Sep 17, 2024
@quiet-node quiet-node modified the milestones: 0.56.0, 0.57.0 Sep 17, 2024
@Nana-EC Nana-EC merged commit 90d1e24 into main Sep 18, 2024
44 checks passed
@Nana-EC Nana-EC deleted the 2906-ci-update-nickfieldsretry-to-step-security-maintained-version branch September 18, 2024 20:50
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (3648684) to head (55320a5).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
+ Coverage   84.48%   89.56%   +5.07%     
==========================================
  Files          40       56      +16     
  Lines        3056     3794     +738     
  Branches      632      772     +140     
==========================================
+ Hits         2582     3398     +816     
- Misses        274      349      +75     
+ Partials      200       47     -153     
Flag Coverage Δ
relay 89.67% <ø> (+5.18%) ⬆️
server 88.30% <ø> (?)
ws-server 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 38 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Update nickfields/retry to step-security maintained version
5 participants