feat: Implement shouldLimit method of HbarLimitService
#2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Yanev <[email protected]>
victor-yanev
changed the title
HbarLimitServiceHbarLimitService#shouldLimit
victor-yanev
changed the title
HbarLimitService#shouldLimitshouldLimit method of HbarLimitService
victor-yanev
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
Signed-off-by: Victor Yanev <[email protected]>
|
Ivo-Yankov
approved these changes
Aug 27, 2024
ebadiere
merged commit 712d7e8
into
add-hbar-limit-subscription-repository
15 of 19 checks passed
ebadiere
pushed a commit
that referenced
this pull request
Aug 27, 2024
* feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * chore: remove redundant return Signed-off-by: Victor Yanev <[email protected]> * chore: use custom errors Signed-off-by: Victor Yanev <[email protected]> * chore: use `CacheService` instead of directly using redis client Signed-off-by: Victor Yanev <[email protected]> * fix: build Signed-off-by: Victor Yanev <[email protected]> * fix: conflicting redis port in tests Signed-off-by: Victor Yanev <[email protected]> * chore: do not reconnect client before each test Signed-off-by: Victor Yanev <[email protected]> * chore: rename entities Signed-off-by: Victor Yanev <[email protected]> * chore: add EthAddressPlan entity and repository Signed-off-by: Victor Yanev <[email protected]> * chore: remove redundant interface Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests for redisCache and cacheService Signed-off-by: Victor Yanev <[email protected]> * chore: fix useless tests in cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: small fix in cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: add UML diagram Signed-off-by: Victor Yanev <[email protected]> * chore: simplify UML-diagram.md Signed-off-by: Victor Yanev <[email protected]> * chore: rename entities Signed-off-by: Victor Yanev <[email protected]> * fix: cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: in-memory redis server port in ethAddressPlanRepository.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: revert unneeded changes in cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * feat: Implement `shouldLimit` method of `HbarLimitService` (#2887) * feat: Create skeleton for `HbarLimitService` Signed-off-by: Victor Yanev <[email protected]> * test: add hbarLimitService.spec.ts Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> Signed-off-by: Victor Yanev <[email protected]>
victor-yanev
added a commit
that referenced
this pull request
Aug 28, 2024
…2883) * feat: Add entities for the redesigned hbar limiter Signed-off-by: Victor Yanev <[email protected]> * feat: Add repositories for the redesigned hbar limiter (#2870) * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * feat: add hbar limit entities and repository Signed-off-by: Victor Yanev <[email protected]> * chore: remove redundant return Signed-off-by: Victor Yanev <[email protected]> * chore: use custom errors Signed-off-by: Victor Yanev <[email protected]> * chore: use `CacheService` instead of directly using redis client Signed-off-by: Victor Yanev <[email protected]> * fix: build Signed-off-by: Victor Yanev <[email protected]> * fix: conflicting redis port in tests Signed-off-by: Victor Yanev <[email protected]> * chore: do not reconnect client before each test Signed-off-by: Victor Yanev <[email protected]> * chore: rename entities Signed-off-by: Victor Yanev <[email protected]> * chore: add EthAddressPlan entity and repository Signed-off-by: Victor Yanev <[email protected]> * chore: remove redundant interface Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests for redisCache and cacheService Signed-off-by: Victor Yanev <[email protected]> * chore: fix useless tests in cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: small fix in cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: add UML diagram Signed-off-by: Victor Yanev <[email protected]> * chore: simplify UML-diagram.md Signed-off-by: Victor Yanev <[email protected]> * chore: rename entities Signed-off-by: Victor Yanev <[email protected]> * fix: cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: in-memory redis server port in ethAddressPlanRepository.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: revert unneeded changes in cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * feat: Implement `shouldLimit` method of `HbarLimitService` (#2887) * feat: Create skeleton for `HbarLimitService` Signed-off-by: Victor Yanev <[email protected]> * test: add hbarLimitService.spec.ts Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: rename specs to match the names of the repositories Signed-off-by: Victor Yanev <[email protected]> * chore: use uuidV4 for mocked data in hbarLimitService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * test: extend hbarLimitService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * test: remove duplicated tests in hbarLimitService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: add types to jsdocs where missing Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> Signed-off-by: Victor Yanev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a skeleton for the
HbarLimitServiceand implements theshouldLimitmethod.NOTE: IP address limiting will be handled in a separate PR after #2867 is merged
Related issue(s):
Fixes #2865
Notes for reviewer:
Checklist