feat: redis cache should fallback to internal in case of error

[natanasow]

Description:

Currently, in the cacheService.ts the methods are written in a way that suggests that if an error occurs in Redis during set and getAsync operations we will fallback to the internal cache. However, this doesn't happen.

Related issue(s):

Fixes #2788

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Acceptance Tests

  21 files  293 suites   30m 44s ⏱️
615 tests 606 ✔️ 4 💤 5 ❌
996 runs  985 ✔️ 4 💤 7 ❌

Results for commit 0e02e97.

♻️ This comment has been updated with latest results.

[github-actions]

Tests

       3 files     207 suites   17s ⏱️
1 052 tests 1 051 ✔️ 1 💤 0 ❌
1 064 runs  1 063 ✔️ 1 💤 0 ❌

Results for commit 0e02e97.

♻️ This comment has been updated with latest results.

[github-actions]

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled should execute "eth_chainId". This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: Scavenge
Cost: 11,608.5 ms

Heap Statistics (before vs after executing the test):

• Total Heap Size: increased with 1.95 MB
• Total Heap Size Executable: no changes
• Total Physical Size: increased with 1.95 MB
• Total Available Size: increased with 10.79 MB
• Total Global Handles Size: no changes
• Used Global Handles Size: decreased with 352.00 bytes
• Used Heap Size: decreased with 10.28 MB
• Heap Size Limit: no changes
• Malloced Memory: no changes
• External Memory: no changes
• Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

• Old Space:

  • Space Size: increased with 2.10 MB
  • Space Used Size: increased with 3.08 MB
  • Space Available Size: decreased with 1.05 MB
  • Physical Space Size: increased with 2.10 MB

• Large Object Space:

  • Space Size: increased with 434.18 KB
  • Space Used Size: increased with 421.07 KB
  • Space Available Size: no changes
  • Physical Space Size: increased with 434.18 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (af09470) to head (0e02e97).
Report is 6 commits behind head on main.

Files	Patch %	Lines
...elay/src/lib/services/cacheService/cacheService.ts	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
+ Coverage   82.66%   83.05%   +0.38%     
==========================================
  Files          49       49              
  Lines        3554     3559       +5     
  Branches      751      751              
==========================================
+ Hits         2938     2956      +18     
+ Misses        370      357      -13     
  Partials      246      246              

Flag	Coverage Δ
relay	82.57% <83.33%> (+0.73%)	⬆️
server	81.19% <ø> (ø)
ws-server	97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...elay/src/lib/services/cacheService/cacheService.ts	97.22% <91.66%> (+20.41%)	⬆️

... and 6 files with indirect coverage changes