feat: remove unnecessary empty Trie initialization
#2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
natanasow
requested review from
victor-yanev,
acuarica,
konstantinabl,
quiet-node and
Ivo-Yankov
victor-yanev
previously approved these changes
Aug 19, 2024
Signed-off-by: nikolay <[email protected]>
|
natanasow
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
victor-yanev
approved these changes
Aug 22, 2024
natanasow
deleted the
2839-remove-unnecessary-empty-trie-initialization
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
+ Coverage 80.14% 81.19% +1.05%
==========================================
Files 30 46 +16
Lines 2709 3403 +694
Branches 582 712 +130
==========================================
+ Hits 2171 2763 +592
- Misses 344 415 +71
- Partials 194 225 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The empty trie root hash can be defined as constant because it can't be changed so there is no actual gain in performance or code readability. The initialization of an empty trie here can be deprecated and replaced with a constant variable.
Solution:
Remove the initialization here and define a new constant that wraps an empty trie root hash.
Related issue(s):
Fixes #2839
Notes for reviewer:
Checklist