-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stabilized sdkClient test by bumping total timeout to 30000ms #2817
Conversation
Signed-off-by: Logan Nguyen <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
+ Coverage 80.66% 81.06% +0.40%
==========================================
Files 30 46 +16
Lines 2689 3386 +697
Branches 577 707 +130
==========================================
+ Hits 2169 2745 +576
- Misses 334 420 +86
- Partials 186 221 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
-stabilized sdkClient test by bumping total timeout to 30000ms
Related issue(s):
Fixes #2816
Notes for reviewer:
Checklist