Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stabilized sdkClient test by bumping total timeout to 30000ms #2817

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

quiet-node
Copy link
Member

Description:
-stabilized sdkClient test by bumping total timeout to 30000ms

Related issue(s):

Fixes #2816

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node linked an issue Aug 13, 2024 that may be closed by this pull request
@quiet-node quiet-node self-assigned this Aug 13, 2024
@quiet-node quiet-node added the enhancement New feature or request label Aug 13, 2024
@quiet-node quiet-node added this to the 0.55.0 milestone Aug 13, 2024
Copy link

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

Tests

       3 files     201 suites   39s ⏱️
1 005 tests 1 004 ✔️ 1 💤 0
1 018 runs  1 017 ✔️ 1 💤 0

Results for commit e4f477f.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (0485787) to head (e4f477f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
+ Coverage   80.66%   81.06%   +0.40%     
==========================================
  Files          30       46      +16     
  Lines        2689     3386     +697     
  Branches      577      707     +130     
==========================================
+ Hits         2169     2745     +576     
- Misses        334      420      +86     
- Partials      186      221      +35     
Flag Coverage Δ
relay 80.66% <ø> (ø)
server 81.53% <ø> (?)
ws-server 97.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

Copy link
Contributor

@victor-yanev victor-yanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Aug 13, 2024

Acceptance Tests

  22 files  247 suites   34m 14s ⏱️
613 tests 597 ✔️ 4 💤 12
733 runs  716 ✔️ 4 💤 13

Results for commit e4f477f.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere merged commit 44d41b8 into main Aug 13, 2024
39 of 40 checks passed
@ebadiere ebadiere deleted the 2816-stable-sdkclient-unit-tests branch August 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stable SDKClient unit tests
3 participants