feat: calculate logsBloom for synthetic transactions
#2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
natanasow
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
2 tasks
This was referenced Aug 6, 2024
Closed
natanasow
requested review from
konstantinabl,
acuarica,
quiet-node,
Ivo-Yankov and
georgi-l95
victor-yanev
requested changes
Aug 7, 2024
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
victor-yanev
previously approved these changes
Aug 8, 2024
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
==========================================
+ Coverage 77.80% 80.07% +2.27%
==========================================
Files 43 47 +4
Lines 3329 3478 +149
Branches 706 736 +30
==========================================
+ Hits 2590 2785 +195
+ Misses 493 429 -64
- Partials 246 264 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
georgi-l95
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently with our synthetic transactions, which are constructed on the fly using events from the operations, we don't return adequate and real logsBloom. This might be a problem for some tools, which requires logsBloom for their operation.
Solution:
We can easily calculate logsBloom for each receipt, this can be done, by taking a look at how it's implemented in the javascript execution client for Ethereum here
Related issue(s):
Fixes #2664
Notes for reviewer:
Checklist