fix: Fix description of authorization of Hedera account #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description is just wrong: Nothing is signed, a signature is verifed as usual. Signed-off-by: David S Bakin <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Michael Garber <[email protected]>
mgarbs
approved these changes
May 22, 2024
kimbor
pushed a commit
to kimbor/hedera-improvement-proposal
that referenced
this pull request
Jun 24, 2024
Signed-off-by: David S Bakin <[email protected]> Signed-off-by: Michael Garber <[email protected]> Co-authored-by: Michael Garber <[email protected]> Signed-off-by: Kim Rader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Description of how
isAuthorizedRawhandles an ED signature for a Hedera account is just wrong: Nothing is signed, a signature is verifed as usual.