-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hedera ledger ID hip #198
Merged
Merged
Hedera ledger ID hip #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimiHunjan <[email protected]>
✔️ Deploy Preview for hedera-hips ready! 🔨 Explore the source changes: 820bf0c 🔍 Inspect the deploy log: https://app.netlify.com/sites/hedera-hips/deploys/618965da7be71300072b6bc5 😎 Browse the preview: https://deploy-preview-198--hedera-hips.netlify.app |
Signed-off-by: SimiHunjan <[email protected]>
Updated header formatting Signed-off-by: Serg Metelin <[email protected]>
Signed-off-by: Serg Metelin <[email protected]>
sergmetelin
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xJepsen
pushed a commit
to 0xJepsen/hedera-improvement-proposal
that referenced
this pull request
Dec 3, 2021
* main ledger ID hip Signed-off-by: SimiHunjan <[email protected]> * Update status Signed-off-by: SimiHunjan <[email protected]> * Update hip-0000-ledger-id.md Updated header formatting Signed-off-by: Serg Metelin <[email protected]> * Rename hip-0000-ledger-id.md to hip-198.md Signed-off-by: Serg Metelin <[email protected]> Co-authored-by: Serg Metelin <[email protected]> Signed-off-by: Waylon Jepsen <[email protected]>
jayv80
pushed a commit
to jayv80/hedera-improvement-proposal
that referenced
this pull request
Dec 20, 2021
* main ledger ID hip Signed-off-by: SimiHunjan <[email protected]> * Update status Signed-off-by: SimiHunjan <[email protected]> * Update hip-0000-ledger-id.md Updated header formatting Signed-off-by: Serg Metelin <[email protected]> * Rename hip-0000-ledger-id.md to hip-198.md Signed-off-by: Serg Metelin <[email protected]> Co-authored-by: Serg Metelin <[email protected]> Signed-off-by: VercammenJo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SimiHunjan [email protected]
Description:
Hedera ledger ID HIP
HIP 15 and 33 will be updated to reference this HIP for Hedera network ledger IDs
Related issue(s):
Fixes #
Notes for reviewer:
Checklist