Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collision of variable name with imported package name #64

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

votdev
Copy link
Member

@votdev votdev commented Feb 4, 2025

Problem:
The variable name networks collides with an imported package name.

Solution:
Rename variable.

Related Issue:
harvester/harvester#7502

@votdev votdev self-assigned this Feb 4, 2025
Copy link
Collaborator

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@starbops starbops merged commit 01bc900 into harvester:main Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants