-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e rework: test_vm_actions.py #940
Conversation
971b392
to
976e8d4
Compare
976e8d4
to
b046536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to rename _cb
to something more explicit one like default_cb
which may ease further code tracing and maintenance.
4fbc1cb
to
6cca196
Compare
6cca196
to
f386460
Compare
Tested on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some minor comments.
Changes
vm_shell_from_host
,vm_checker
to eliminate duplicated codetest_restore_replace_vm_not_stop
fortest_restore_backup_vm_on
in legacy codetest_backup_migrated_vm
andtest_restore_replace_migrated_vm
fortest_backup_restore_migrated_vm_[s3|nfs]
in legacy codetest_restore_replace_migrated_vm
be marked skipped because [BUG] Restoring the backup of Live Migrated VM , starts VM back on the original node where the backup was taken harvester#1473test_backup_restore
base_vm
separated frombase_vm_with_data
base_vm_migrated
TestBackupRestore
test_update_backup_by_yaml
to fortest_update_backup_yaml_[s3|nfs]
in legacy codeapi.backups.update
restored_vm_name
to fit the correct backup-target. (change to lower case because [BUG] Unable to restore backup into new VM when the name starts with upper case harvester#4544)