Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform new upgradelog naming and check before create upgrade #1785

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conform new upgradelog naming and check before create upgrade #1785

merged 2 commits into from
Jan 16, 2025

Conversation

albinsun
Copy link
Contributor

@albinsun albinsun commented Jan 14, 2025 •
edited
Loading

Which issue(s) this PR fixes:

  1. Fix [e2e] [BUG] UpgradeLog can't be ready cause of fluentd PVC doesn't give access mode #1448
    • Add test case test_upgrade.py::TestAnyNodesUpgrade::test_verify_upgradelog
    • Enhance upgradelog pod naming check
  2. Check upgrade version do created before create upgrade job
    • Refactoring an upgrade_check fixture

What this PR does / why we need it:

Fix failed upgrade test cases and enhance stability

Special notes for your reviewer:

Additional documentation or context

  1. Verification
    image

@albinsun albinsun mentioned this pull request Jan 14, 2025
Closed
@lanfon72
Copy link
Member

as it is related to harvester/harvester#6272 also update the test issue #1448

@albinsun
Copy link
Contributor Author

albinsun commented Jan 15, 2025 •
edited
Loading

as it is related to harvester/harvester#6272 also update the test issue #1448

Add upgradelog pod and volume check for #1448
cc. @lanfon72

Verification

  • Report
    image
  • Result
    image

lanfon72
lanfon72 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo-rancher khushboo-rancher merged commit d1cbf45 into harvester:main Jan 16, 2025
4 checks passed
@albinsun albinsun deleted the enhance_upgrade_job_check branch January 17, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-rancher khushboo-rancher khushboo-rancher approved these changes

@lanfon72 lanfon72 lanfon72 approved these changes

@irishgordo irishgordo Awaiting requested review from irishgordo

@TachunLin TachunLin Awaiting requested review from TachunLin

@noahgildersleeve noahgildersleeve Awaiting requested review from noahgildersleeve

Assignees
No one assigned
Labels
area/backend-automation Implement with pytest area/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] [BUG] UpgradeLog can't be ready cause of fluentd PVC doesn't give access mode
3 participants
@albinsun @lanfon72 @khushboo-rancher