-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEP: Update MTU and NAD #6385
HEP: Update MTU and NAD #6385
Conversation
9614b57
to
2c183c1
Compare
BTW, to reviewer: This is an open discussion about the potential enhancement to the networking related feature in Harvester, more than the single MTU issue. Please feel free to leave your comments, thanks. |
a3326eb
to
08f6558
Compare
Signed-off-by: Jian Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be specified whether MTU or MTU
should be used in the document. But then it should be consistent.
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
FYI: With more investigation and analysis, I just added a second commit. A short summary: https://github.com/w13915984028/harvester/blob/hepmtu/enhancements/20240820-mtu-and-network-information-propagation.md#short-summary |
Signed-off-by: Jian Wang <[email protected]>
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
enhancements/20240820-mtu-and-network-information-propagation.md
Outdated
Show resolved
Hide resolved
The summary of HEP review meeting: (1) V1.4.0 will focus on manual operation of chaning MTU, with a document and essential enhancements on code. |
Signed-off-by: Jian Wang <[email protected]>
This PR is stale because it has been open for 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open for 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
The MTU is not fully synced between different objects, users also have some questions.
Solution:
Review the MTU belonging and the enhancement to current network controller.
Related Issue:
#4355
Test plan: