Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEP: Update MTU and NAD #6385

Closed
wants to merge 3 commits into from
Closed

Conversation

w13915984028
Copy link
Member

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

The MTU is not fully synced between different objects, users also have some questions.

Solution:

Review the MTU belonging and the enhancement to current network controller.

Related Issue:
#4355

Test plan:

@w13915984028
Copy link
Member Author

BTW, to reviewer:

This is an open discussion about the potential enhancement to the networking related feature in Harvester, more than the single MTU issue. Please feel free to leave your comments, thanks.

@w13915984028 w13915984028 force-pushed the hepmtu branch 6 times, most recently from a3326eb to 08f6558 Compare August 20, 2024 14:48
Signed-off-by: Jian Wang <[email protected]>
Copy link
Member

@votdev votdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be specified whether MTU or MTU should be used in the document. But then it should be consistent.

@w13915984028
Copy link
Member Author

FYI: With more investigation and analysis, I just added a second commit.

A short summary: https://github.com/w13915984028/harvester/blob/hepmtu/enhancements/20240820-mtu-and-network-information-propagation.md#short-summary

@w13915984028
Copy link
Member Author

The summary of HEP review meeting:

(1) V1.4.0 will focus on manual operation of chaning MTU, with a document and essential enhancements on code.
(2) V1.5.0 will consider to add a controller to sync the MTU from clusternetwork to vlanconfig and NAD.
(3) V1.5.0 will add an enhancement for the management network: check if MTU of management network on each node is same.

Copy link

This PR is stale because it has been open for 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the status/stale stale issue label label Oct 15, 2024
@starbops starbops removed the status/stale stale issue label label Oct 15, 2024
Copy link

This PR is stale because it has been open for 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the status/stale stale issue label label Nov 30, 2024
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale stale issue label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants