fix: failed to create vm template on Rancher managed Harvester #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi-Ya Chen <[email protected]>
houhoucoop
commented
Dec 30, 2024
|
|
||
| updateNameNsDescriptionValue(newValue) { | ||
| this.templateValue.metadata.name = newValue.metadata.name; | ||
| this.templateValue.metadata.namespace = newValue.metadata.namespace; |
There was a problem hiding this comment.
The issue is that line 166 is missing this.templateValue?.metadata?.name in create mode.
Fix it by updating templateValue as the user types.
a110605
reviewed
Jan 1, 2025
| @@ -226,7 +231,7 @@ export default { | |||
| :mode="realTemplateMode" | |||
| name-label="harvester.vmTemplate.nameNsDescription.name" | |||
| :namespaced="true" | |||
| @update:value="$emit('update:value', $event)" | |||
| @update:value="updateNameNsDescriptionValue" | |||
There was a problem hiding this comment.
The update value should be templateValue which matches the logic in saveVMT(), even there is no parent component needs $emit('update:templateValue', $event), but it's fine and existing pattern for NameNsDescription to emit an action. (You can search <NameNsDescription in harvester-ui-extension)
<NameNsDescription
:value="templateValue"
:mode="realTemplateMode"
name-label="harvester.vmTemplate.nameNsDescription.name"
:namespaced="true"
@update:value="$emit('update:templateValue', $event)"
/>
Remember to update emits: ['update:templateValue'] in line 32.
There was a problem hiding this comment.
Update in commit 4d48e75.
Signed-off-by: Yi-Ya Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unable to create vm template on Rancher managed Harvester successfully
PR Checklists
Related Issue
[BUG] Failed to create vm template on Rancher managed Harvester #7183
Test screenshot/video
Screen.Recording.2024-12-30.at.4.58.04.PM.mov
Extra technical notes summary