Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide v-dropdown arrow #42

Merged
merged 1 commit into from
Nov 26, 2024
Merged

hide v-dropdown arrow #42

merged 1 commit into from
Nov 26, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Nov 26, 2024 •
edited
Loading

Summary

Change another way to hide v-dropdown arrow. Previous way does not work if user didn't enter images page.

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#7040

Test screenshot/video

Also fix the same issue in vGPU page
Screenshot 2024-11-26 at 5 43 56 PM

@a110605
hide v-dropdown arrow
a7bb166 
Signed-off-by: andy.lee <[email protected]>
@a110605 a110605 requested a review from torchiaf November 26, 2024 09:46
torchiaf
torchiaf approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@torchiaf torchiaf merged commit 8a5f425 into harvester:main Nov 26, 2024
1 check passed
@a110605 a110605 deleted the issue-7040-2 branch February 21, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a110605 @torchiaf