Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in PCI Devices page #41

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix bugs in PCI Devices page #41

merged 1 commit into from
Nov 26, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Nov 26, 2024

Summary

Fix

  • Create from YAML Button is missing
  • Filter popup position is overlay to parent button

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#7040

Test screenshot/video

after fix

Screenshot 2024-11-26 at 5 20 07 PM

Extra technical notes summary

@a110605 a110605 requested a review from torchiaf November 26, 2024 09:22
@a110605 a110605 self-assigned this Nov 26, 2024
@@ -81,8 +81,10 @@ export default {
</span>

<v-dropdown
popper-class="filter-label"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class filter-label css was added globally.

.filter-label .v-popper__arrow-container {
display: none;

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 63994c1 into harvester:main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants