Sure DHCP will work on VLAN interface if VLAN is configured

[w13915984028]

Problem:

DHCP looks to have flaws with VLAN interfaces.

Solution:

Sure the DHCP is working on VLAN interface if VLAN is configured.

This PR has 3 commits:

(1) Use VLAN interface if VLAN is configured to do DHCP
(2) Avoid preflight check if node goes to dashboard directly
(3) Pass VID

PR #878 is merged to this one.

Co-authored-by: Kiefer Chang [email protected]

Related Issue:

harvester/harvester#6959
harvester/harvester#3428

Test plan:

Per issue description

Local test:

Installer with this fix, the DHCP discovery frame is encaped with VLAN 100 ( and we did not set a DHCP server on VLAN 100)

Original installer without this fix, the DHCP discovery frame is NOT encaped with VLAN 100

[w13915984028]

@mergify backport v1.4 v1.3

[mergify]

backport v1.4 v1.3

✅ Backports have been created

• #880 Sure DHCP will work on VLAN interface if VLAN is configured (backport #879) has been created for branch v1.4
• #881 Sure DHCP will work on VLAN interface if VLAN is configured (backport #879) has been created for branch v1.3 but encountered conflicts

[w13915984028]

Another hidden bug: in the code path, the VID is not copid in function configureInstallModeDHCP and passed to next level

addInstallPanel -> configureInstallModeDHCP -> applyNetworks -> UpdateManagementInterfaceConfig -> updateBridge

[tserong]

LGTM!

[mingshuoqiu]

LGTM

[starbops]

LGTM, thank you.