build: add installer commit hash to /etc/harvester-release.yaml (backport #791) #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
For release builds, this should give us something like the following, which includes the commit hash from harvester-installer: installer: ff64884 os: Harvester v1.3 For local dev builds, it's a bit redundant, but I don't think there's any harm in this: installer: 677447c os: Harvester 677447c-dirty Related issue: harvester/harvester#6285 Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 7d89bd6)
bk201
approved these changes
Aug 19, 2024
tserong
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It's not always obvious exactly which version of the harvester-installer code is included in a given build.
Solution:
Add the harvester-installer commit hash to
/etc/harvester-release.yaml. For release builds, this should give us something like the following:For local dev builds, it's a bit redundant, but I don't think there's any harm in this:
Related Issue:
harvester/harvester#6285
Test plan:
Run
cat /etc/harvester-releaseand make sure theosline includes the harvester-installer commit hash in parentheses.This is an automatic backport of pull request #791 done by [Mergify](https://mergify.com).