Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force remove files (rm -f), so the install script doesn't fail if the files don't exist.
Problem:
Sometimes the installer may hit a problem where it tries to remove a file that isn't there. If that happens, it shouldn't crash, but rather try to continue and recover.
Solution:
The solution is to use the
-f
flag for therm
command in the respective bash script. This flag causesrm
to exit with a successful return code if the file didn't exist in the first place, or when the file was successfully removed. Thus the script can continue on when the file it tries to remove already didn't exist anyways.Related Issue:
Test plan: