Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Harvester management chart is modified #701

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

bk201
Copy link
Member

@bk201 bk201 commented Apr 15, 2024

Problem:

Harvester ManagedChart is in modified status.

Solution:

Ignore the status fields on some Longhorn CRDs.

Related Issue:

harvester/harvester#5566

Test plan:

  • Create a new cluster.

  • Run kubectl get bundles -n fleet-local mcc-harvester, the BUNDLEDEPLOYMENTS-READY should be 1/1 and STATUS should be empty. For example:

    NAME            BUNDLEDEPLOYMENTS-READY   STATUS
    mcc-harvester   1/1
    

Ignore the status fields in some CRDs.

Signed-off-by: Kiefer Chang <[email protected]>
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test with fresh installation

harvester-node-0:~ # kubectl get bundles -A
NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             1/1
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 1/1
fleet-local   mcc-harvester-crd                             1/1
fleet-local   mcc-local-managed-system-upgrade-controller   1/1
fleet-local   mcc-rancher-logging-crd                       1/1
fleet-local   mcc-rancher-monitoring-crd                    1/1

@Vicente-Cheng Vicente-Cheng merged commit 65636ce into harvester:v1.2 Apr 15, 2024
5 checks passed
@bk201
Copy link
Member Author

bk201 commented May 23, 2024

@Mergifyio backport master v1.3

Copy link

mergify bot commented May 23, 2024

backport master v1.3

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants