Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to v1.21 #684

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Bump golang to v1.21 #684

merged 2 commits into from
Mar 28, 2024

Conversation

votdev
Copy link
Member

@votdev votdev commented Mar 25, 2024

Problem:
Go v1.20 is EOL on 06 Feb 2024.

Solution:
Bump golang to v1.21.

Related Issue:
harvester/harvester#5310

@votdev votdev self-assigned this Mar 25, 2024
@votdev votdev force-pushed the issue_5310_go_1.21 branch from ee44ca5 to 5c9d924 Compare March 25, 2024 11:41
@votdev
Bump golang to v1.21
9feb8cd 
Signed-off-by: Volker Theile <[email protected]>
@votdev votdev force-pushed the issue_5310_go_1.21 branch from 5c9d924 to 9feb8cd Compare March 25, 2024 12:57
@votdev votdev marked this pull request as ready for review March 26, 2024 12:45
tserong
tserong approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. OOC, why the change from run.skip-files and .skip-dirs to issues.exclude-files and .exclude-dirs? I've not looked at golangci config before, so just wondering why one form would be preferred over the other.

@votdev
Copy link
Member Author

votdev commented Mar 27, 2024

LGTM. OOC, why the change from run.skip-files and .skip-dirs to issues.exclude-files and .exclude-dirs? I've not looked at golangci config before, so just wondering why one form would be preferred over the other.

run.skip-files and run.skip-dirs are deprecated. Both the linter and my IDE reported errors here.

⚠️ Replace run.skip-xxx options by issues.exclude-xxx options
See https://golangci-lint.run/product/changelog/#v1570

@tserong
Copy link
Contributor

tserong commented Mar 27, 2024

Aha! Thanks, I didn't find that when looking at the docs earlier today. I still have a browser tab open which mentions run.skip-files:

image

...but I've just now reloaded that page and it's changed to now show issues.exclude-files (and ..dirs) at https://golangci-lint.run/usage/configuration/#issues-configuration.

It would seem I was simply extremely unlucky with my timing when reviewing this ;-)

bk201
bk201 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the effort!

@FrankYang0529 FrankYang0529 mentioned this pull request Mar 28, 2024
Merged
FrankYang0529
FrankYang0529 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can provision a cluster with PR harvester/harvester#5454

Vicente-Cheng
Vicente-Cheng approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for it!

@Vicente-Cheng Vicente-Cheng merged commit dd16a95 into harvester:master Mar 28, 2024
5 checks passed
@FrankYang0529
Copy link
Member

@mergify backport v1.3

@mergify Mergify
Copy link

mergify bot commented Apr 1, 2024 •
edited
Loading

backport v1.3

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 1, 2024
Merged
@FrankYang0529
Copy link
Member

@mergify backport v1.2

@mergify Mergify
Copy link

mergify bot commented Apr 17, 2024 •
edited
Loading

backport v1.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
@votdev votdev deleted the issue_5310_go_1.21 branch May 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

@bk201 bk201 bk201 approved these changes

@Vicente-Cheng Vicente-Cheng Vicente-Cheng approved these changes

@tserong tserong tserong approved these changes

Assignees

@votdev votdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@votdev @tserong @FrankYang0529 @Vicente-Cheng @bk201