Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build missed charts #676

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

w13915984028
Copy link
Member

Problem:

Some charts are missed.

Solution:

Add then back

Related Issue:
harvester/harvester#5337

Test plan:

build log:

...
Successfully packaged chart and saved it to: /go/src/github.com/harvester/harvester-installer/package/harvester-repo/charts/rancher-logging-103.0.0+up3.17.10.tgz
finish patch ranch-logging chart
pull harvester-vm-import-controller: 0.1.7
pull harvester-pcidevices-controller: 0.3.2
pull harvester-seeder: 0.1.1
...

@bk201
Copy link
Member

bk201 commented Mar 11, 2024

There was a PR to fix it, I'm good to close mine: #674

@bk201
Copy link
Member

bk201 commented Mar 11, 2024

need to fix the image list too:

if [ "{ARCH}" == "amd64" ]

@w13915984028
Copy link
Member Author

@bk201 co-author with you

Signed-off-by: Jian Wang <[email protected]>

Co-authored-by: Kiefer Chang <[email protected]>
@bk201
Copy link
Member

bk201 commented Mar 11, 2024

Confirm charts are packaged and I can enable the add-ons.

harvester-cluster-repo-6d9fb84bb4-x9hk2:/ # ls /srv/www/htdocs/charts/ -alh
total 1.3M
drwxr-xr-x 2 root root 4.0K Mar 11 13:56 .
drwxr-xr-x 1 root root 4.0K Mar 11 13:56 ..
-rw-r--r-- 1 root root 210K Mar 11 13:53 harvester-0.0.0-master-53a1eaa6.tgz
-rw-r--r-- 1 root root  66K Mar 11 13:53 harvester-crd-0.0.0-master-53a1eaa6.tgz
-rw-r--r-- 1 root root 2.8K Mar 11 13:53 harvester-pcidevices-controller-0.3.2.tgz
-rw-r--r-- 1 root root 3.0K Mar 11 13:53 harvester-seeder-0.1.1.tgz
-rw-r--r-- 1 root root 2.6K Mar 11 13:53 harvester-vm-import-controller-0.1.7.tgz
-rw-r--r-- 1 root root  12K Mar 11 13:53 index.yaml
-rw-r--r-- 1 root root 2.5K Mar 11 13:53 nvidia-driver-runtime-0.1.1.tgz
-rw-r--r-- 1 root root  15K Mar 11 13:53 rancher-logging-103.0.0+up3.17.10.tgz
-rw-r--r-- 1 root root  82K Mar 11 13:53 rancher-logging-crd-103.0.0+up3.17.10.tgz
-rw-r--r-- 1 root root 417K Mar 11 13:53 rancher-monitoring-103.0.3+up45.31.1.tgz
-rw-r--r-- 1 root root 398K Mar 11 13:53 rancher-monitoring-crd-103.0.3+up45.31.1.tgz

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@markhillgit markhillgit merged commit 5d69c52 into harvester:master Mar 11, 2024
5 checks passed
@bk201
Copy link
Member

bk201 commented Mar 12, 2024

@Mergifyio backport v1.3

Copy link

mergify bot commented Mar 12, 2024

backport v1.3

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants