Clarify wording of VirtCheck failure, fix weird line wrapping #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Serong <[email protected]>
Without this fix, if you're extremely unlucky with window size and string length, the wrap performed by gocui's View.draw() function will inject an extra linebreak at the same place we already injected one, leading to annoyingly weird displays like this: ``` Only 19GiB RAM detected. Harvester requires at least 32GiB for testing and 64GiB for production use. ``` Signed-off-by: Tim Serong <[email protected]>
connorkuehl
approved these changes
Feb 9, 2024
| panelWidth := p.X1 - p.X0 | ||
| // Need to subtract 1 from panelWidth here to match the view.Size() | ||
| // calculation done in gocui's view.Draw() function | ||
| panelWidth := p.X1 - p.X0 - 1 |
There was a problem hiding this comment.
Is there any chance at all of this becoming negative? Would that be bad or does gocui do the right thing and just occlude anything that's not on the page?
There was a problem hiding this comment.
I don't believe it's possible for that to ever end up negative, but just in case I'm wrong there's an if panelWidth > 0 to ensure our wrapping doesn't kick in if the dimensions are bogus :-)
|
FYI: With the fix #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When running under virtualization the current warning message says "System is virtualized (kvm) which is not supported", but should say "not supported in production". Also, in some cases, there's extra linebreaks in the warning messages, e.g.:
Solution:
This PR
Related Issue:
harvester/harvester#1154
Test plan:
N/A