Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump go to v1.20.10 #578

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

FrankYang0529
Copy link
Member

Problem:
We used go 1.18, which is EOL in 2023/02.

Solution:
Bump golang to v1.20.10.

Related Issue:
https://github.com/harvester/security/issues/38

@FrankYang0529 FrankYang0529 force-pushed the HARV-SEC-38 branch 2 times, most recently from 95c1068 to 02940cc Compare October 23, 2023 08:52
@FrankYang0529 FrankYang0529 requested a review from bk201 October 23, 2023 09:39
@bk201 bk201 requested review from Vicente-Cheng and removed request for bk201 October 23, 2023 09:39
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Vicente-Cheng
Copy link
Contributor

Should we change this line https://github.com/harvester/harvester-installer/blob/master/Dockerfile.dapper#L21 for go1.20?

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Vicente-Cheng Vicente-Cheng merged commit 3abd2f4 into harvester:master Nov 3, 2023
@Vicente-Cheng
Copy link
Contributor

@Mergifyio backport v1.2

Copy link

mergify bot commented Nov 3, 2023

backport v1.2

✅ Backports have been created

@Vicente-Cheng
Copy link
Contributor

@Mergifyio backport v1.1

Copy link

mergify bot commented Nov 3, 2023

backport v1.1

✅ Backports have been created

@FrankYang0529 FrankYang0529 deleted the HARV-SEC-38 branch November 3, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants