Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: always set log level to debug when we install #570

Merged
merged 1 commit into from
Nov 1, 2023
Merged

common: always set log level to debug when we install #570

merged 1 commit into from
Nov 1, 2023

Conversation

Vicente-Cheng
Copy link
Contributor

Problem:
Try to get more logs when we use the elemental command.

Solution:
Add debug parameter

Related Issue:
harvester/harvester#4541

Test plan:
make sure the installation as usual

@Vicente-Cheng
common: always set log level to debug when we install
94c3f9a 
    - Always set the debug level when we use the elemental command.
      That does not make too many logs because the installation is
      oneshot behavior.

Signed-off-by: Vicente Cheng <[email protected]>
masteryyh
masteryyh approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@masteryyh masteryyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested installation successful with a lot of logs.
BTW, why don't we add another GRUB menu entry for debug mode? It's somewhat confusing when seeing a lot of message outputs compares to earlier versions.

guangbochen
guangbochen approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Vicente-Cheng
Copy link
Contributor Author

LGTM, tested installation successful with a lot of logs. BTW, why don't we add another GRUB menu entry for debug mode? It's somewhat confusing when seeing a lot of message outputs compares to earlier versions.

Thanks @masteryyh for this question!
Did you mean the rd.debug for the grub parameter?
That will not only affect the elemental output but will append more like dracut ... etc.

For the installation, we might not set the debug flag as default because we could try again and add rd.debug or --debug for it.
But we need to add a debug flag as default for the upgrade because we could not try again easily.

If you all thought we could add a debug flag once an error happened on installation, I will close this PR.
Feel free to give some thoughts on it! Thanks!! cc @bk201, @guangbochen, @masteryyh

@bk201 bk201 merged commit dc17aec into harvester:master Nov 1, 2023
@bk201
Copy link
Member

bk201 commented Nov 1, 2023

@Mergifyio backport v1.2

@mergify Mergify
Copy link

mergify bot commented Nov 1, 2023 •
edited
Loading

backport v1.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@guangbochen guangbochen guangbochen approved these changes

@masteryyh masteryyh masteryyh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vicente-Cheng @bk201 @guangbochen @masteryyh