Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon updates #547

Merged
merged 1 commit into from
Jul 19, 2023
Merged

addon updates #547

merged 1 commit into from
Jul 19, 2023

Conversation

ibrokethecloud
Copy link
Contributor

PR introduces addon updates for

  • pcidevices-controller
  • vm-import-controller
  • seeder

Problem:

Solution:

Related Issue:

Test plan:

@ibrokethecloud
package vm-import-controller v0.1.5
2a43ef5 
update pcidevices and seeder addon
@bk201
Copy link
Member

bk201 commented Jul 19, 2023

@Mergifyio backport v1.2

@mergify
Copy link

mergify bot commented Jul 19, 2023 •
edited
Loading

backport v1.2

✅ Backports have been created

@bk201 bk201 requested a review from guangbochen July 19, 2023 10:32
bk201
bk201 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Verify 3 add-ons are installed in air-gapped env.

guangbochen
guangbochen approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@guangbochen guangbochen merged commit 5a24751 into harvester:master Jul 19, 2023
@mergify mergify bot mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@guangbochen guangbochen guangbochen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibrokethecloud @bk201 @guangbochen