-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change installation disk space limit to 180Gi when using different disk for data. #528
Conversation
7c4ba4c
to
82655f0
Compare
ee71a83
to
f780d18
Compare
FYI: It's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Test Plan Passed. Just a small suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, validated that both multi-disk and single-disk installation contains the correct partition.
vda 253:0 0 193273528320 0 disk
├─vda1 253:1 0 1048576 0 part
├─vda2 253:2 0 67108864 0 part /oem
├─vda3 253:3 0 4294967296 0 part
├─vda4 253:4 0 8589934592 0 part /run/initramfs/cos-state
└─vda5 253:5 0 180318371840 0 part /var/lib/longhorn
/var/crash
/var/lib/third-party
/var/lib/cni
/var/lib/wicked
/var/lib/kubelet
/var/lib/rancher
/var/log
/usr/libexec
/root
/opt
/home
/etc/pki/trust/anchors
/etc/cni
/etc/iscsi
/etc/ssh
/etc/rancher
/etc/systemd
/usr/local
vdb 253:16 0 53687091200 0 disk /var/lib/harvester/defaultdisk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. need squash commits
fa181b8
to
574b1a1
Compare
Excellent job; the merge makes the UX better. Can we wait for one more enter before proceeding to the next page when using a data disk? It's too rushed to jump to the next page immediately: Screen.Recording.2023-07-13.at.4.18.24.PM.mov |
98e128c
to
79a34e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
79a34e6
to
389fba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: masteryyh <[email protected]>
389fba1
to
4150f42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for it! Let's wait for the CI.
@mergify backport v1.2 |
✅ Backports have been created
|
Problem:
When selecting different disk for data, 250Gi limit for installation disk is too large.
Solution:
Change the limit to 180Gi when using different disk for data.
Related Issue:
harvester/harvester#4133
Test plan:
ISO Installation
Single Disk
Multiple Disk
PXE Installation
Single disk
Multiple disk