Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rancher-monitoring-crd 102.0.0+up40.1.2 chart RBAC issue #505

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

w13915984028
Copy link
Member

Problem:

The rancher-monitoring-crd is not fully installed, and error log is observed in harvester/harvester#3969.

The root cause is that the chart installer job has RBAC issue.

Solution:

Fix the RBAC

Related Issue:
Harvester: harvester/harvester#3969

Upstream: rancher/rancher#43418

Test plan:

  1. Befor this PR, when enable rancher-monitoring addon, the error message is observed per [BUG] failed to update status subresource: prometheuses.monitoring.coreos.com "rancher-monitoring-prometheus" not found harvester#3969

  2. With this PR, when enable rancher-monitoring addon, the error message is gone.

** Other **
make log:

...
patch original file ./rancher-monitoring-crd/templates/rbac.yaml
-rw-r--r-- 1 root root 1.7K Mar 14 17:51 ./rancher-monitoring-crd/templates/rbac.yaml
diff
12c12
<   verbs: ['create', 'get', 'patch', 'delete']
---
>   verbs: ['create', 'get', 'patch', 'delete', 'update']
patched file
-rw-r--r-- 1 root root 1.7K Jun 11 21:21 ./rancher-monitoring-crd/templates/rbac.yaml
Successfully packaged chart and saved it to: /go/src/github.com/harvester/harvester-installer/package/harvester-repo/charts/rancher-monitoring-crd-102.0.0+up40.1.2.tgz
finish patch ranch-monitoring-crd chart

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @w13915984028 Can we have an issue to remove the workaround once the upsteam issue is fixed and when we need to bump the version again? Thank you

@w13915984028
Copy link
Member Author

LGTM, @w13915984028 Can we have an issue to remove the workaround once the upsteam issue is fixed and when we need to bump the version again? Thank you

@bk201 Let's follow with harvester/harvester#4063 .
Review &/ remove the local patch to upstream Rancher charts

Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@guangbochen guangbochen merged commit fc5d876 into harvester:master Jun 12, 2023
@guangbochen
Copy link
Contributor

@mergify backport v1.2

@mergify
Copy link

mergify bot commented Jun 12, 2023

backport v1.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants