add random number generator and log improvement #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vicente-Cheng
commented
Jul 14, 2023
•
Vicente-Cheng
commented
- add a random number generator. We could use this with a boundary value.
- improve the watcher log
- add configuration of linter
Signed-off-by: Vicente Cheng <[email protected]>
This was referenced Jul 14, 2023
Vicente-Cheng
force-pushed
the
add-random-and-improve-log
branch
2 times, most recently
from
7f0d947 to
7a31572
Compare
bk201
reviewed
Jul 17, 2023
- you could generate the random number with boundary value - add unit test Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
add-random-and-improve-log
branch
from
7a31572 to
f1b13e5
Compare
bk201
reviewed
Jul 17, 2023
- also fix the linter warning
- also bump to go v1.19
Signed-off-by: Vicente Cheng <[email protected]>
Co-authored-by: Kiefer Chang <[email protected]>
Vicente-Cheng
force-pushed
the
add-random-and-improve-log
branch
from
ee46c73 to
0703777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.