Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command and ns libs #16

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

Vicente-Cheng
Copy link
Collaborator

Mainly move the command and namespace libs to the go-common
(Previously located on the NDM)

I thought the executor might be useful for us (actually, I need this for csi-driver-lvm), so I would like to move here.

Also, do some file reorg and misc improvement.

    - Also correct the package description

Signed-off-by: Vicente Cheng <[email protected]>
    - remove dummy file

Signed-off-by: Vicente Cheng <[email protected]>
Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng
Copy link
Collaborator Author

I will update other packages once it merged.

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@bk201 bk201 merged commit 22ebbe4 into harvester:main Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants