Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for how to install rancher-alerting-drivers #713

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

brandboat
Copy link
Member

related to harvester/harvester#7369, add documentation for installing rancher-alerting-drivers in Harvester v1.3, v1.4, and the latest versions.

Copy link

github-actions bot commented Feb 7, 2025

Name Link
🔨 Latest commit 6406516
😎 Deploy Preview https://67ad9891b16d365d5195a440--harvester-preview.netlify.app

Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the document, please also add more informtion for user convenience.

Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

@brandboat
Copy link
Member Author

Addressed comments and rebased from main branch, @jillian-maroket please take a look when you are available, thank you!

Signed-off-by: Cooper Tseng <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants