Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(dhcp): add features and limitations sections #701

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

starbops
Copy link
Member

@starbops starbops commented Jan 6, 2025

Elaborate on the strengths and weaknesses of the managed DHCP add-on so users can better understand what they can get by enabling the add-on.

Related issue: harvester/harvester#7272

@starbops starbops marked this pull request as ready for review January 6, 2025 05:51
Copy link

github-actions bot commented Jan 6, 2025

Name Link
🔨 Latest commit 2104275
😎 Deploy Preview https://677c87cf2f6fcc17b3ccd7a6--harvester-preview.netlify.app

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

docs/advanced/addons/managed-dhcp.md Outdated Show resolved Hide resolved
docs/advanced/addons/managed-dhcp.md Outdated Show resolved Hide resolved
@starbops
Copy link
Member Author

starbops commented Jan 7, 2025

@jillian-maroket I've updated the PR according to the suggestions. Please take a look. Thank you.

@starbops starbops merged commit 29ff10c into harvester:main Jan 7, 2025
3 checks passed
@starbops starbops deleted the doc-7272 branch January 7, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants