Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default eviction strategy to LiveMigrateIfPossible #980

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Change default eviction strategy to LiveMigrateIfPossible #980

merged 1 commit into from
Apr 29, 2024

Conversation

connorkuehl
Copy link

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related issue harvester/harvester#5495

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@connorkuehl
Copy link
Author

@torchiaf Do you prefer 2 approvals on dashboard PRs or is this good to go?

@torchiaf torchiaf requested a review from bk201 April 15, 2024 14:39
@torchiaf
Copy link
Collaborator

@torchiaf Do you prefer 2 approvals on dashboard PRs or is this good to go?

@connorkuehl I added Kiefer, thanks.

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bk201 bk201 merged commit bbc89cc into harvester:master Apr 29, 2024
8 checks passed
@torchiaf
Copy link
Collaborator

@mergify backport release-harvester-v1.2 release-harvester-v1.3

Copy link

mergify bot commented Apr 29, 2024

backport release-harvester-v1.2 release-harvester-v1.3

✅ Backports have been created

torchiaf added a commit that referenced this pull request May 2, 2024
…v1.3/pr-980

Change default eviction strategy to LiveMigrateIfPossible (backport #980)
torchiaf added a commit that referenced this pull request May 2, 2024
…v1.2/pr-980

Change default eviction strategy to LiveMigrateIfPossible (backport #980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants